Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the list of courses and faculty for the upcoming semester. #257

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

honeysyrup2526
Copy link

@honeysyrup2526 honeysyrup2526 commented Nov 6, 2024

Addresses #256

@syedomar1 syedomar1 mentioned this pull request Nov 9, 2024
@syedomar1
Copy link
Contributor

@honeysyrup2526 @vatz88
image
The file format is not according to the schema which is required

@vatz88
Copy link
Owner

vatz88 commented Nov 11, 2024

@syedomar1 is it just the column headers or data is missing?
Would it be possible for you to make a fix?

@syedomar1
Copy link
Contributor

They don't have type and the credits column.
Does that work?

@vatz88
Copy link
Owner

vatz88 commented Nov 12, 2024

They don't have type and the credits column. Does that work?

That should be fine. Could you test it using the preview link?
https://deploy-preview-257--ffcsonthego.netlify.app/

@vatz88
Copy link
Owner

vatz88 commented Nov 12, 2024

Looks broken to me

Screenshot_20241111-194701

@syedomar1
Copy link
Contributor

syedomar1 commented Nov 12, 2024

Yeah, its broken.
Shall I try making the required changes and open a modified PR and see if that works?
But yeah I don't think students will be able to keep a check on total credits and stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants