Skip to content

Commit

Permalink
fix(xo-server): disable broken requestTimeout
Browse files Browse the repository at this point in the history
Fixes https://xcp-ng.org/forum/post/58146

Caused by nodejs/node#46574

It caused requests to timeout after 0-30 seconds, which broke all uploads.
  • Loading branch information
julien-f authored and MathieuRA committed Mar 7, 2023
1 parent acadf49 commit 17f83e3
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.unreleased.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
- [Continuous Replication] Fix `VDI_IO_ERROR` when after a VDI has been resized
- [REST API] Fix VDI import
- Fix failing imports (REST API and web UI) [Forum#58146](https://xcp-ng.org/forum/post/58146)

### Packages to release

Expand Down
5 changes: 4 additions & 1 deletion packages/xo-server/config.toml
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,10 @@ port = 80
#
# This breaks a number of XO use cases, for instance uploading a VDI via the
# REST API, therefore it's changed to 1 day.
requestTimeout = 86400000
#
# Completely disabled for now because it appears to be broken:
# https://github.com/nodejs/node/issues/46574
requestTimeout = 0

[http.mounts]
'/' = '../xo-web/dist'
Expand Down

0 comments on commit 17f83e3

Please sign in to comment.