Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for allowing cpu and memory updates to the vm resource #144

Merged

Conversation

ddelnano
Copy link
Collaborator

@ddelnano ddelnano commented Apr 27, 2021

This addresses #111 and #40

Todo

  • Decide the final scope of this change
    • Should the other missing vm.set attributes be supported?
    • Should the breaking change to support the necessary cpu and memory toggles be made?
    • The breaking changes and full support of the vm.set parameters will be done in a later PR
  • Add test that ensures that VM is not shutdown when cpu change is within cpu max
  • Add test that ensure that VM is not shutdown when memory change is within memory limits
  • Clean up the mocking code needed to validate that online cpu and memory changes work as expected
  • Create github issue to track supporting the other vm.set parameters in the vm resource update (Support missing parameters in vm.set for Vm updates #145)
  • make testacc and make testclient pass
    • make testclient passes
    • make acctest passes

@ddelnano ddelnano merged commit 0bb5963 into master Apr 30, 2021
@ddelnano
Copy link
Collaborator Author

This will be released in v0.19.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant