Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 与 OpenDAL 集成以支持更多服务 #87

Merged
merged 1 commit into from
Aug 23, 2023
Merged

feat: 与 OpenDAL 集成以支持更多服务 #87

merged 1 commit into from
Aug 23, 2023

Conversation

silver-ymz
Copy link
Contributor

@silver-ymz silver-ymz commented Aug 23, 2023

此PR还未准备好合并

complete #85

此PR添加了 OpenDAL 的集成。 理论上可以支持 https://opendal.apache.org/docs/rust/opendal/services/index.html 中的所有服务。 但由于需要获取文件的可下载链接,所以只能支持具有 presign 功能的服务,包括 Azblob, Gcs, Oss, Obs, S3, Wasabi
后续,也许可以修改 https://github.com/vastsa/FileCodeBox/blob/master/apps/base/views.py#L85 支持文件通过服务器中转下载,进而支持 OpenDAL 的所有服务。

存在的问题:
OpenDAL 实现了 presign 功能,但还未在 python binding 中暴露出来。因此, get_file_url 的实现目前是无法运行的。

cc @vastsa , 如果作者接受这个 PR 的话,我可以在 OpenDAL 打开一个 issue, 并完成暴露 presign API 的工作

相关的 issues: #66, #68, #69

Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
@silver-ymz silver-ymz marked this pull request as draft August 23, 2023 08:57
@vastsa vastsa marked this pull request as ready for review August 23, 2023 21:47
@vastsa vastsa merged commit 920ded4 into vastsa:master Aug 23, 2023
@vastsa
Copy link
Owner

vastsa commented Aug 23, 2023

可以先临时通过服务器中转一下哦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants