Fix: Move renderSearchSuggestion outside component to prevent functio… #121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #89 by moving the
renderSearchSuggestionfunction outside theSearchSuggestionscomponent definition to prevent creating a new function on each render.Problem
Previously,
renderSearchSuggestionwas defined inside theSearchSuggestionscomponent, which meant a new function was created every time the component re-rendered. This is inefficient and can cause unnecessary re-renders of child components.Solution
Moved
renderSearchSuggestionoutside the component definition so it's only created once and reused across renders.Changes
renderSearchSuggestionfunction definition aboveSearchSuggestionscomponentpatterns/15.list-components.mdBeforeript
const SearchSuggestions = (props) => {
const renderSearchSuggestion = listItem => (
);
// ...
};
Afterscript
const renderSearchSuggestion = listItem => (
const SearchSuggestions = (props) => {
// ...
};
Fixes #89