Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

param: Off by one maximum http_req_overflow_status #4306

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

param: Off by one maximum http_req_overflow_status #4306

wants to merge 1 commit into from

Conversation

dridi
Copy link
Member

@dridi dridi commented Mar 31, 2025

Spotted during a discussion with @walid-git.

@nigoroll
Copy link
Member

Hm, this was actually deliberate on my end, but sure, we can change it.

@dridi
Copy link
Member Author

dridi commented Mar 31, 2025

I'm pretty sure I was initially of the same opinion until I discussed it with Walid and gave actual thought to this angle.

nigoroll
nigoroll approved these changes Mar 31, 2025
View reviewed changes
Copy link
Member

@nigoroll nigoroll left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+0, no strong feelings either way.
(but I would appreciate to not use "off by one" for the title)

@bsdphk
Copy link
Contributor

bsdphk commented Apr 9, 2025

ok with me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nigoroll nigoroll nigoroll approved these changes

Assignees
No one assigned
Labels
b=enhancement c=varnishd r=trunk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dridi @nigoroll @bsdphk