introduce VRT_VSC_AllocVariadic #4303
Conversation
VRT_VSC_Alloc requires `va_list` which isn't available on all platforms in `rust`. To bridge this FFI gap, provide a variadic version of it.
| @@ -824,6 +824,10 @@ void VRT_VSM_Cluster_Destroy(VRT_CTX, struct vsmw_cluster **); | |||
| #ifdef va_start // XXX: hackish | |||
There was a problem hiding this comment.
side note: I'm not sure this ifdef is justified anymore? There's no alternative for VRT_VSC_Alloc if it isn't defined, and we systematically rely on that function, don't we?
| void * | ||
| VRT_VSC_AllocVariadic(struct vsmw_cluster *vc, struct vsc_seg **sg, |
There was a problem hiding this comment.
I would have suggested VRT_VSC_Allocv() to match what we do in other places but in this case it's completely backwards :-/
|
I agree with @dridi that the name is non-C-ish, but I'll refrain from making suggestions, what with bikesheds and whats not. |
gquintard
force-pushed
the
VRT_VSC_AllocVariadic
branch
2 times, most recently
from
204a945 to
2976944
Compare
|
so, |
No.
|
That's a sneaky breaking change, but that would be the correct move. You'd need two extra entries in the VRT history:
|
VRT_VSC_Alloc requires
va_listwhich isn't available on all platforms inrust. To bridge this FFI gap, provide a variadic version of it.