Add values.schema.json
#36
Conversation
|
Will fix the issues failing the tests and mark this as |
| # command: | ||
| # - sh -c "sleep 3600" | ||
|
|
||
| # Declares the extra sidecar containers to run with Varnish pods. Can be set as either |
There was a problem hiding this comment.
I updated this as these containers don't appear (will double check) to be configured to run as "true" sidecar containers (initContainers.restartPolicy: always)
I'd love to open up a follow up PR to implement the ability to specify extra containers to run as sidecars!
| # Configures a probe for checking if a Pod has started. | ||
| startupProbe: {} | ||
| #startupProbe: | ||
| # initialDelaySeconds: 5 | ||
| # periodSeconds: 10 | ||
| # timeoutSeconds: 1 | ||
| # successThreshold: 1 | ||
| # failureThreshold: 3 | ||
|
|
There was a problem hiding this comment.
This appears to be a duplicate of the block on lines 493-499
| "description": "sets the deployment kind (Deployment, StatefulSet or DaemonSet)", | ||
| "type": "string", | ||
| "pattern": "^(Deployment|StatefulSet|DaemonSet)$" |
There was a problem hiding this comment.
Originally didn't have Daemonset set here - unsure if this will work or if I should exclide the pattern for this key
| "clusterIP": { | ||
| "description": "whether to attach a cluster IP to the service", | ||
| "type": "string", | ||
| "pattern": "^$|^(?:([0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])\\.){3}([0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])$" |
There was a problem hiding this comment.
This gross regex should validate for IPV4 address or an empty string, can remove, or come up with a worse one for IPV6 😆
|
Ahh I see my issue, new to |
1 participant
Adding a
values.schema.jsonfile for validating thevalues.yamlStill a work in progress but should be done soon!
Will close #17