Skip to content

Override SQLDataType.blob to BYTEA for SQLKit users - #264

Merged
gwynne merged 1 commit into
mainfrom
blob-postgres
May 2, 2024
Merged

Override SQLDataType.blob to BYTEA for SQLKit users#264
gwynne merged 1 commit into
mainfrom
blob-postgres

Conversation

@gwynne

@gwynne gwynne commented May 2, 2024

Copy link
Copy Markdown
Member

These changes are now available in 2.13.3

Fluent already does this for users of FluentPostgresDriver, this just adds the same behavior to the equivalent data type at the SQLKit layer.

@gwynne gwynne added bug Something isn't working semver-patch Internal changes only labels May 2, 2024
@gwynne
gwynne requested review from 0xTim, MahdiBM, dannflor and ptoffy May 2, 2024 08:16
@codecov

codecov Bot commented May 2, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 41.20%. Comparing base (9535dc5) to head (eef600a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #264      +/-   ##
==========================================
+ Coverage   41.18%   41.20%   +0.02%     
==========================================
  Files          13       13              
  Lines         845      847       +2     
==========================================
+ Hits          348      349       +1     
- Misses        497      498       +1     
Files Coverage 螖
Sources/PostgresKit/PostgresDialect.swift 78.26% <50.00%> (-0.85%) 猬囷笍

@ptoffy

ptoffy commented May 2, 2024

Copy link
Copy Markdown
Member

Actually why is this crashing on the nightlies?

@gwynne
gwynne merged commit ad8ae1e into main May 2, 2024
@gwynne
gwynne deleted the blob-postgres branch May 2, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working semver-patch Internal changes only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants