Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous bug fixes #610

Merged
merged 11 commits into from
May 30, 2024
Merged

Miscellaneous bug fixes #610

merged 11 commits into from
May 30, 2024

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented May 29, 2024

These changes are now available in 1.48.5

This update contains the following fixes and changes:

  • Logging (especially of Fluent queries) is now done in structured fashion using metadata, as recommended for logging in libraries.
  • Several superfluous Sendable workarounds have been removed (they were never needed).
  • Resolved several DocC warnings.
  • When using eager loading with @CompositeChildren properties, specifying withDeleted: true now works (previously the flag was ignored).
  • query.aggregate(.custom(.sql(...))) now works correctly (previously only plain strings were handled for custom aggregates)
  • Fixed a FluentBenchmarks test so that it actually tests what it claims to.
  • Fixed numerous FluentBenchmarks tests so they no longer crash if something goes wrong during migrations.
  • ISO8601TimestampFormat now correctly respects the milliseconds setting on a case-by-case basis when used in both modes in the same application (the behavior was previously nondeterministic).

@gwynne gwynne added bug Something isn't working semver-patch Internal changes only labels May 29, 2024
@gwynne gwynne requested review from 0xTim, MahdiBM and ptoffy May 29, 2024 19:14
Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 16.60900% with 241 lines in your changes are missing coverage. Please review.

Project coverage is 24.74%. Comparing base (cb91bf9) to head (6554e35).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #610      +/-   ##
==========================================
- Coverage   25.02%   24.74%   -0.28%     
==========================================
  Files         149      149              
  Lines        8593     8648      +55     
==========================================
- Hits         2150     2140      -10     
- Misses       6443     6508      +65     
Files Coverage Δ
Sources/FluentBenchmark/FluentBenchmarker.swift 0.00% <ø> (ø)
...urces/FluentBenchmark/Tests/PerformanceTests.swift 0.00% <ø> (ø)
...rces/FluentKit/Concurrency/Model+Concurrency.swift 25.00% <ø> (ø)
Sources/FluentKit/Properties/CompositeID.swift 87.50% <100.00%> (ø)
Sources/FluentKit/Properties/Group.swift 68.25% <100.00%> (ø)
Sources/FluentKit/Properties/ID.swift 80.00% <100.00%> (-1.09%) ⬇️
Sources/FluentKit/Properties/OptionalField.swift 83.07% <100.00%> (-0.51%) ⬇️
Sources/FluentKit/Properties/Timestamp.swift 84.88% <100.00%> (ø)
...ry/Builder/QueryBuilder+Join+DirectRelations.swift 100.00% <ø> (ø)
Sources/FluentKit/Schema/DatabaseSchema.swift 54.54% <ø> (ø)
... and 42 more

gwynne added 2 commits May 29, 2024 14:49
…1TimestampFormat when both fractional and non-fractional formats are used in the same project.
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are you using for formatting? I feel like we should probably try and commit that to VCS to try and make PRs consistent

@gwynne gwynne merged commit d69efce into main May 30, 2024
9 of 12 checks passed
@gwynne gwynne deleted the misc-bugfixes branch May 30, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working semver-patch Internal changes only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants