Update self-test to automatically test against more options of the reusable workflow #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
<Let's see how it goes, not sure if things will just work right off the bat> |
gwynne
requested changes
Oct 24, 2024
.github/workflows/self-test.yml
Outdated
Comment on lines
5
to
34
| with_coverage: | ||
| type: boolean | ||
| required: false | ||
| default: true | ||
| description: "Set to 'true' to collect and upload code coverage data. Defaults to 'false'." | ||
| with_tsan: | ||
| type: boolean | ||
| required: false | ||
| default: true | ||
| description: "Set to 'true' to run tests with Thread Sanitizer. Defaults to 'true'." | ||
| warnings_as_errors: | ||
| type: boolean | ||
| required: false | ||
| default: false | ||
| description: "Set to 'true' to treat warnings as errors. Defaults to 'false'." | ||
| with_api_check: | ||
| type: boolean | ||
| required: false | ||
| default: true | ||
| description: "Set to 'true' to run the SwiftPM public API breakage check. Defaults to 'true'." | ||
| with_gh_codeql: | ||
| type: boolean | ||
| required: false | ||
| default: true | ||
| description: "Set to 'true' to run CodeQL checks. Defaults to 'true'." | ||
| with_linting: | ||
| type: boolean | ||
| required: false | ||
| default: false | ||
| description: "Set to 'true' to run swift-format's lint process. Defaults to 'false'." |
There was a problem hiding this comment.
Why remove these? These are inputs to the workflow_dispatch event, which means "when manually run from the GitHub UI". Just change the defaults.
gwynne
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.