Draft
Conversation
scottmarchant
commented
Dec 12, 2025
Member
|
@scottmarchant as mentioned in the other PR, we can't consider adding any dependencies until they hit at least a 1.0 |
Author
@0xTim If the new wasm-only dependencies were released as version 1.0 or later, would there be any other issues regarding adding the new dependencies? |
scottmarchant
commented
Dec 15, 2025
Author
|
Per conversations with vapor core team, moving this to draft until a version of swift-nio is merged that supports the needed changes here. Please ignore changes pushed here while in draft. I'll mention reviewers in a comment once I move this back out of draft. |
…latforms that don't support Dispatch.
f230f36 to
5a09ab7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for compiling async-kit to wasm using the Swift SDK for WebAssembly.
This PR is part of a larger effort by a company called PassiveLogic to enable broad support for Swift WebAssembly.
Details
Dispatchsupport in the Swift SDK for WebAssemblyNIOEmbeddedandNIOPosixfrom theAsyncKittarget. These imports are only used in the test target.Testing done
swift build --swift-sdk swift-6.3-DEVELOPMENT-SNAPSHOT-2025-12-07-a_wasm --target AsyncKitcompletes without errors. This is the latest daily snapshot of the swift toolchain.Usage notes
The current Swift 6.2.x breaks certain wasm executors that make testing wasm executables like this impossible. To fully test this running in the browser, recommend using Swift 6.3.x or later.
Impact Risk
If anyone depends solely on the removed exports for their documentation, their builds may break. But since NIOPosix and NIOEmbedded aren't used in the target anymore, it makes sense to remove those exports from the
AsyncKittarget.