Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update product and model names #6

Merged
merged 7 commits into from
Jun 25, 2024
Merged

Update product and model names #6

merged 7 commits into from
Jun 25, 2024

Conversation

fpseverino
Copy link
Member

@fpseverino fpseverino commented Jun 24, 2024

  • Update package to Swift 5.10
  • Change the product name to Passes in preparation for the addition of the Orders module
  • Update names of structs and properties to better represent what they are
  • Make updatedAt and createdAt properties actual @Timestamps
  • Update README.md
  • Improve DooC and add .spi.yml

@fpseverino fpseverino requested a review from gwynne June 24, 2024 17:31
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 61 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (99fa653) to head (cd69220).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main      #6   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         11      11           
  Lines        517     420   -97     
=====================================
+ Misses       517     420   -97     
Files Coverage Δ
Sources/Passes/DTOs/PassesForDeviceDTO.swift 0.00% <ø> (ø)
...ources/Passes/Middleware/ApplePassMiddleware.swift 0.00% <ø> (ø)
Sources/Passes/Models/PassKitDevice.swift 0.00% <ø> (ø)
Sources/Passes/Models/PassKitErrorLog.swift 0.00% <ø> (ø)
Sources/Passes/Models/PassKitPassData.swift 0.00% <ø> (ø)
Sources/Passes/PassesDelegate.swift 0.00% <ø> (ø)
Sources/Passes/URL+Extension.swift 0.00% <ø> (ø)
Sources/Passes/Models/PassKitRegistration.swift 0.00% <0.00%> (ø)
Sources/Passes/Models/ConcreteModels.swift 0.00% <0.00%> (ø)
Sources/Passes/Models/PassKitPass.swift 0.00% <0.00%> (ø)
... and 1 more

README.md Outdated Show resolved Hide resolved
@fpseverino fpseverino requested a review from 0xTim June 25, 2024 21:06
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpseverino fpseverino merged commit a6d96ec into vapor-community:main Jun 25, 2024
10 checks passed
@fpseverino fpseverino deleted the update branch June 25, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants