Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: support options for wal append methods #96

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

ifplusor
Copy link
Collaborator

@ifplusor ifplusor commented Jun 9, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #96 (0e95a31) into main (164757f) will increase coverage by 0.10%.
The diff coverage is 70.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
+ Coverage   40.69%   40.80%   +0.10%     
==========================================
  Files          92       92              
  Lines        7987     7990       +3     
==========================================
+ Hits         3250     3260      +10     
+ Misses       4486     4479       -7     
  Partials      251      251              
Impacted Files Coverage Δ
internal/raft/log/log.go 0.00% <0.00%> (ø)
internal/store/meta/async.go 0.00% <0.00%> (ø)
internal/store/meta/sync.go 0.00% <0.00%> (ø)
internal/store/wal/wal.go 66.96% <74.28%> (+3.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 164757f...0e95a31. Read the comment docs.

@ifplusor ifplusor force-pushed the refactor-wal-append branch from c3a655b to 0e95a31 Compare June 9, 2022 12:52
@ifplusor ifplusor requested a review from xdlbdy June 9, 2022 12:55
Copy link
Contributor

@xdlbdy xdlbdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ifplusor ifplusor merged commit 7a98bde into main Jun 9, 2022
@ifplusor ifplusor deleted the refactor-wal-append branch June 13, 2022 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants