Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vsctl): create ns,eb,sub with id #613

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xdlbdy
Copy link
Contributor

@xdlbdy xdlbdy commented Aug 10, 2023

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Signed-off-by: xdlbdy <xdlbdy@gmail.com>
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #613 (adcf895) into main (ee76217) will decrease coverage by 3.04%.
Report is 81 commits behind head on main.
The diff coverage is 46.52%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #613      +/-   ##
==========================================
- Coverage   57.07%   54.04%   -3.04%     
==========================================
  Files         190      224      +34     
  Lines       15191    18081    +2890     
==========================================
+ Hits         8670     9771    +1101     
- Misses       5884     7517    +1633     
- Partials      637      793     +156     
Files Changed Coverage Δ
internal/controller/trigger/storage/storage.go 0.00% <ø> (ø)
...rnal/controller/trigger/validation/subscription.go 62.64% <ø> (ø)
internal/controller/trigger/worker/manager.go 85.76% <ø> (+0.83%) ⬆️
internal/controller/trigger/worker/policy.go 100.00% <ø> (ø)
internal/controller/trigger/worker/scheduler.go 71.01% <ø> (+1.01%) ⬆️
internal/controller/trigger/worker/worker.go 78.45% <ø> (-1.55%) ⬇️
internal/gateway/config.go 60.60% <ø> (-0.51%) ⬇️
internal/gateway/gateway.go 57.64% <ø> (-10.03%) ⬇️
internal/gateway/proxy/auth.go 0.00% <ø> (ø)
internal/gateway/proxy/deadletter.go 0.00% <ø> (ø)
... and 68 more

... and 67 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2735bb4...adcf895. Read the comment docs.

@ifplusor ifplusor changed the title feat: vsctl add id for ns,eb,sub create feat(vsctl): create ns,eb,sub with id Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant