Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): use host as store address #601

Merged
merged 1 commit into from
May 29, 2023

Conversation

ifplusor
Copy link
Collaborator

What problem does this PR solve?

Issue Number: None

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Signed-off-by: James Yin <ywhjames@hotmail.com>
@ifplusor ifplusor added enhancement New feature or request co/store relating to store labels May 16, 2023
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #601 (040b10d) into main (ee76217) will decrease coverage by 2.53%.
The diff coverage is 46.82%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #601      +/-   ##
==========================================
- Coverage   57.07%   54.54%   -2.53%     
==========================================
  Files         190      211      +21     
  Lines       15191    17043    +1852     
==========================================
+ Hits         8670     9296     +626     
- Misses       5884     7042    +1158     
- Partials      637      705      +68     
Impacted Files Coverage Δ
internal/controller/trigger/storage/storage.go 0.00% <ø> (ø)
...ernal/controller/trigger/validation/subscripton.go 66.12% <ø> (-3.17%) ⬇️
internal/controller/trigger/worker/manager.go 85.76% <ø> (+0.83%) ⬆️
internal/controller/trigger/worker/policy.go 100.00% <ø> (ø)
internal/controller/trigger/worker/scheduler.go 71.01% <ø> (+1.01%) ⬆️
internal/controller/trigger/worker/worker.go 78.45% <ø> (-1.55%) ⬇️
internal/gateway/config.go 60.60% <ø> (-0.51%) ⬇️
internal/gateway/gateway.go 57.64% <ø> (-10.03%) ⬇️
internal/gateway/proxy/auth.go 0.00% <ø> (ø)
internal/gateway/proxy/deadletter.go 0.00% <ø> (ø)
... and 70 more

... and 57 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1da8b81...040b10d. Read the comment docs.

@ifplusor ifplusor merged commit 43db43b into vanus-labs:main May 29, 2023
@ifplusor ifplusor deleted the store-addr branch May 29, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
co/store relating to store enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants