Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert rpcerr to ErrorType #580

Merged
merged 1 commit into from
Mar 28, 2023
Merged

fix: convert rpcerr to ErrorType #580

merged 1 commit into from
Mar 28, 2023

Conversation

hwjiangkai
Copy link
Contributor

What problem does this PR solve?

convert rpcerr to ErrorType

Before modification:

controller       | time="2023-03-28T11:37:04Z" level=error msg="failed to create RetryEventbus, exit" error="rpc error: code = Unknown desc = {\"description\":\"volume instance not found\",\"message\":\"\",\"code\":9405}"

After modification

controller       | time="2023-03-28T11:56:22Z" level=error msg="failed to create RetryEventbus, exit" error="{\"description\": \"volume instance not found\",\"code\":9405}"

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #580 (93633fd) into main (ee76217) will decrease coverage by 2.34%.
The diff coverage is 39.65%.

❗ Current head 93633fd differs from pull request most recent head a3359d2. Consider uploading reports for the commit a3359d2 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #580      +/-   ##
==========================================
- Coverage   57.07%   54.73%   -2.34%     
==========================================
  Files         190      211      +21     
  Lines       15191    16918    +1727     
==========================================
+ Hits         8670     9260     +590     
- Misses       5884     6960    +1076     
- Partials      637      698      +61     
Impacted Files Coverage Δ
internal/controller/eventbus/block/selector.go 91.48% <ø> (-8.52%) ⬇️
internal/controller/trigger/storage/storage.go 0.00% <ø> (ø)
internal/controller/trigger/worker/policy.go 100.00% <ø> (ø)
internal/gateway/proxy/auth.go 0.00% <0.00%> (ø)
internal/gateway/proxy/deadletter.go 0.00% <0.00%> (ø)
internal/gateway/proxy/util.go 0.00% <0.00%> (ø)
internal/primitive/authentication/client.go 0.00% <0.00%> (ø)
internal/primitive/authorization/action.go 0.00% <0.00%> (ø)
internal/primitive/authorization/client.go 0.00% <ø> (ø)
internal/primitive/authorization/role.go 83.01% <ø> (ø)
... and 74 more

... and 55 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe9d312...a3359d2. Read the comment docs.

Signed-off-by: jyjiangkai <jyjiangkai@163.com>
@ifplusor ifplusor merged commit 9938385 into main Mar 28, 2023
@hwjiangkai hwjiangkai deleted the error branch March 28, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants