Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deploy vanus cluster based on yaml #546

Merged
merged 1 commit into from
Mar 14, 2023
Merged

fix: deploy vanus cluster based on yaml #546

merged 1 commit into from
Mar 14, 2023

Conversation

hwjiangkai
Copy link
Contributor

What problem does this PR solve?

  1. fix Makefile build image error
  2. fix vanus deploy config based on yaml

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Signed-off-by: jyjiangkai <jyjiangkai@163.com>
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #546 (c80dd3e) into main (ee76217) will decrease coverage by 1.22%.
The diff coverage is 49.11%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #546      +/-   ##
==========================================
- Coverage   57.07%   55.85%   -1.22%     
==========================================
  Files         190      191       +1     
  Lines       15191    15509     +318     
==========================================
- Hits         8670     8663       -7     
- Misses       5884     6200     +316     
- Partials      637      646       +9     
Impacted Files Coverage Δ
internal/controller/eventbus/block/block.go 35.93% <0.00%> (-16.70%) ⬇️
internal/controller/eventbus/block/selector.go 91.66% <ø> (-8.34%) ⬇️
internal/controller/trigger/storage/storage.go 0.00% <ø> (ø)
internal/controller/trigger/worker/policy.go 100.00% <ø> (ø)
internal/gateway/config.go 61.11% <ø> (ø)
internal/gateway/proxy/deadletter.go 0.00% <0.00%> (ø)
internal/primitive/cel/cel.go 68.57% <0.00%> (ø)
...rnal/primitive/interceptor/errinterceptor/error.go 0.00% <0.00%> (ø)
.../primitive/interceptor/memberinterceptor/member.go 0.00% <0.00%> (ø)
internal/primitive/queue/queue.go 87.87% <ø> (ø)
... and 71 more

... and 38 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d41391d...c80dd3e. Read the comment docs.

Copy link
Contributor

@wenfengwang wenfengwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenfengwang wenfengwang merged commit 9f4ca03 into main Mar 14, 2023
wenfengwang pushed a commit that referenced this pull request Mar 23, 2023
Signed-off-by: jyjiangkai <jyjiangkai@163.com>
@hwjiangkai hwjiangkai deleted the fix branch March 24, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants