Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move vanus.ID to pkg #520

Merged
merged 1 commit into from
Mar 28, 2023
Merged

feat: move vanus.ID to pkg #520

merged 1 commit into from
Mar 28, 2023

Conversation

ifplusor
Copy link
Collaborator

What problem does this PR solve?

Issue Number: None

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #520 (29d7ba2) into main (ee76217) will decrease coverage by 2.68%.
The diff coverage is 39.93%.

❗ Current head 29d7ba2 differs from pull request most recent head f53259d. Consider uploading reports for the commit f53259d to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #520      +/-   ##
==========================================
- Coverage   57.07%   54.39%   -2.68%     
==========================================
  Files         190      211      +21     
  Lines       15191    17146    +1955     
==========================================
+ Hits         8670     9327     +657     
- Misses       5884     7121    +1237     
- Partials      637      698      +61     
Impacted Files Coverage Δ
internal/controller/eventbus/block/block.go 35.93% <0.00%> (-16.70%) ⬇️
internal/controller/eventbus/block/selector.go 91.66% <ø> (-8.34%) ⬇️
internal/controller/trigger/storage/storage.go 0.00% <ø> (ø)
internal/controller/trigger/worker/policy.go 100.00% <ø> (ø)
internal/gateway/proxy/auth.go 0.00% <0.00%> (ø)
internal/gateway/proxy/deadletter.go 0.00% <0.00%> (ø)
internal/gateway/proxy/util.go 0.00% <0.00%> (ø)
internal/primitive/authentication/client.go 0.00% <0.00%> (ø)
internal/primitive/authorization/action.go 0.00% <0.00%> (ø)
internal/primitive/authorization/client.go 0.00% <0.00%> (ø)
... and 74 more

... and 46 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c695ff...f53259d. Read the comment docs.

@ifplusor ifplusor changed the title feat(client): use vanus.ID feat: move vanus.ID to pkg Mar 27, 2023
@ifplusor ifplusor marked this pull request as ready for review March 27, 2023 03:04
Signed-off-by: James Yin <ywhjames@hotmail.com>
Copy link
Contributor

@xdlbdy xdlbdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xdlbdy xdlbdy merged commit fe9d312 into vanus-labs:main Mar 28, 2023
@ifplusor ifplusor deleted the dep-id branch March 28, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants