Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change metadata key #512

Merged
merged 6 commits into from
Mar 11, 2023

Conversation

xdlbdy
Copy link
Contributor

@xdlbdy xdlbdy commented Mar 10, 2023

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Signed-off-by: xdlbdy <xdlbdy@gmail.com>
Signed-off-by: xdlbdy <xdlbdy@gmail.com>
Signed-off-by: xdlbdy <xdlbdy@gmail.com>
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #512 (548b017) into main (ee76217) will decrease coverage by 0.59%.
The diff coverage is 54.26%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #512      +/-   ##
==========================================
- Coverage   57.07%   56.48%   -0.59%     
==========================================
  Files         190      190              
  Lines       15191    15351     +160     
==========================================
+ Hits         8670     8671       +1     
- Misses       5884     6033     +149     
- Partials      637      647      +10     
Impacted Files Coverage Δ
internal/controller/eventbus/block/block.go 52.63% <ø> (ø)
internal/controller/eventbus/block/selector.go 100.00% <ø> (ø)
internal/controller/eventbus/server/instance.go 72.04% <ø> (ø)
internal/controller/trigger/storage/storage.go 0.00% <ø> (ø)
internal/controller/trigger/worker/policy.go 100.00% <ø> (ø)
internal/gateway/config.go 61.11% <ø> (ø)
internal/gateway/proxy/deadletter.go 0.00% <0.00%> (ø)
internal/primitive/cel/cel.go 68.57% <0.00%> (ø)
...rnal/primitive/interceptor/errinterceptor/error.go 0.00% <0.00%> (ø)
.../primitive/interceptor/memberinterceptor/member.go 0.00% <0.00%> (ø)
... and 102 more

... and 21 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7c178d...548b017. Read the comment docs.

internal/controller/eventbus/controller.go Outdated Show resolved Hide resolved
internal/kv/constant.go Outdated Show resolved Hide resolved
Signed-off-by: xdlbdy <xdlbdy@gmail.com>
Signed-off-by: xdlbdy <xdlbdy@gmail.com>
Signed-off-by: xdlbdy <xdlbdy@gmail.com>
Copy link
Contributor

@wenfengwang wenfengwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenfengwang wenfengwang merged commit c18230e into vanus-labs:main Mar 11, 2023
wenfengwang pushed a commit that referenced this pull request Mar 23, 2023
* refactor: change metadata key

Signed-off-by: xdlbdy <xdlbdy@gmail.com>

* refactor: change metadata key

Signed-off-by: xdlbdy <xdlbdy@gmail.com>

* refactor: change metadata key

Signed-off-by: xdlbdy <xdlbdy@gmail.com>

* refactor: change metadata key

Signed-off-by: xdlbdy <xdlbdy@gmail.com>

* refactor: change metadata key

Signed-off-by: xdlbdy <xdlbdy@gmail.com>

* refactor: change metadata key

Signed-off-by: xdlbdy <xdlbdy@gmail.com>

---------

Signed-off-by: xdlbdy <xdlbdy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants