feat: change api eventbus name to eventbus id #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xdlbdy <xdlbdy@gmail.com>
xdlbdy
requested review from
hwjiangkai,
ifplusor and
wenfengwang
as code owners
Signed-off-by: xdlbdy <xdlbdy@gmail.com>
Signed-off-by: xdlbdy <xdlbdy@gmail.com>
Signed-off-by: xdlbdy <xdlbdy@gmail.com>
Signed-off-by: xdlbdy <xdlbdy@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #500 +/- ##
==========================================
- Coverage 57.07% 57.06% -0.01%
==========================================
Files 190 191 +1
Lines 15191 15291 +100
==========================================
+ Hits 8670 8726 +56
- Misses 5884 5928 +44
Partials 637 637
Continue to review full report at Codecov.
|
wenfengwang
pushed a commit
that referenced
this pull request
Mar 23, 2023
* feat: eventbus name change to id Signed-off-by: xdlbdy <xdlbdy@gmail.com> * feat: eventbus name change to id Signed-off-by: xdlbdy <xdlbdy@gmail.com> * feat: eventbus name change to id Signed-off-by: xdlbdy <xdlbdy@gmail.com> * feat: eventbus name change to id Signed-off-by: xdlbdy <xdlbdy@gmail.com> * feat: eventbus name change to id Signed-off-by: xdlbdy <xdlbdy@gmail.com> --------- Signed-off-by: xdlbdy <xdlbdy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary
What is changed and how does it work?
Check List
Tests