Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Unit test fixing of TestEventlogManager_UpdateSegmentReplicas #467

Merged
merged 3 commits into from
Feb 28, 2023

Conversation

wenfengwang
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary

Unit test fixing of TestEventlogManager_UpdateSegmentReplicas

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #467 (3e24de2) into main (2a78cb5) will decrease coverage by 0.58%.
The diff coverage is 41.57%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #467      +/-   ##
==========================================
- Coverage   57.71%   57.13%   -0.58%     
==========================================
  Files         180      185       +5     
  Lines       14614    15051     +437     
==========================================
+ Hits         8434     8599     +165     
- Misses       5552     5819     +267     
- Partials      628      633       +5     
Impacted Files Coverage Δ
...ernal/controller/trigger/validation/subscripton.go 69.29% <ø> (+0.85%) ⬆️
internal/gateway/proxy/deadletter.go 0.00% <0.00%> (ø)
internal/gateway/proxy/direct.go 73.33% <0.00%> (-5.24%) ⬇️
internal/store/segment/server.go 14.10% <0.00%> (-0.03%) ⬇️
internal/trigger/client/gcloud_functions.go 0.00% <0.00%> (ø)
internal/trigger/client/grpc.go 0.00% <0.00%> (ø)
internal/trigger/client/http.go 0.00% <0.00%> (ø)
internal/trigger/client/interface.go 0.00% <0.00%> (-19.24%) ⬇️
internal/trigger/client/lambda.go 0.00% <0.00%> (ø)
internal/gateway/proxy/proxy.go 23.08% <6.52%> (-2.01%) ⬇️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e75c679...3e24de2. Read the comment docs.

@wenfengwang wenfengwang merged commit 0a31e3b into main Feb 28, 2023
@ifplusor ifplusor deleted the fix-eventlog-ut branch March 3, 2023 03:38
wenfengwang added a commit that referenced this pull request Mar 23, 2023
…467)

* test: fix TestEventlogManager_UpdateSegmentReplicas

* fix ut data racing

* fix ut
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants