Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: merge append interface #433

Merged
merged 3 commits into from
Feb 17, 2023
Merged

feat!: merge append interface #433

merged 3 commits into from
Feb 17, 2023

Conversation

hwjiangkai
Copy link
Contributor

@hwjiangkai hwjiangkai commented Feb 14, 2023 •
edited
Loading

Signed-off-by: jyjiangkai jyjiangkai@163.com

What problem does this PR solve?

  1. merge append interface
  2. modify the read interface event data structure to CloudEventBatch
  3. mv codec package to proto/pkg/codec
  4. add print log
  5. format import

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@codecov
Copy link

codecov bot commented Feb 14, 2023 •
edited
Loading

Codecov Report

Merging #433 (aa43694) into main (2a78cb5) will decrease coverage by 0.81%.
The diff coverage is 27.75%.

❗ Current head aa43694 differs from pull request most recent head 12fe77c. Consider uploading reports for the commit 12fe77c to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #433      +/-   ##
==========================================
- Coverage   57.71%   56.90%   -0.81%     
==========================================
  Files         180      182       +2     
  Lines       14614    14957     +343     
==========================================
+ Hits         8434     8512      +78     
- Misses       5552     5810     +258     
- Partials      628      635       +7
Impacted Files Coverage Δ
...ernal/controller/trigger/validation/subscripton.go 69.29% <ø> (+0.85%) ⬆️
internal/gateway/proxy/deadletter.go 0.00% <0.00%> (ø)
internal/gateway/proxy/direct.go 73.33% <0.00%> (-5.24%) ⬇️
internal/store/segment/server.go 14.10% <0.00%> (-0.03%) ⬇️
internal/trigger/client/gcloud_functions.go 0.00% <0.00%> (ø)
internal/trigger/client/grpc.go 0.00% <0.00%> (ø)
internal/trigger/client/http.go 0.00% <0.00%> (ø)
internal/trigger/client/interface.go 0.00% <0.00%> (-19.24%) ⬇️
internal/trigger/client/lambda.go 0.00% <0.00%> (ø)
internal/gateway/proxy/proxy.go 23.08% <6.52%> (-2.01%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b3837f...12fe77c. Read the comment docs.

@hwjiangkai
refactor: merge append interface
c9b0a03 
Signed-off-by: jyjiangkai <jyjiangkai@163.com>
ifplusor
ifplusor requested changes Feb 16, 2023
View reviewed changes
client/pkg/api/client.go Outdated Show resolved Hide resolved
client/pkg/api/client.go Outdated Show resolved Hide resolved
client/internal/vanus/eventlog/name_service.go Outdated Show resolved Hide resolved
client/pkg/eventlog/eventlog.go Outdated Show resolved Hide resolved
client/pkg/eventlog/eventlog_impl.go Outdated Show resolved Hide resolved
client/pkg/eventlog/log_segment.go Outdated Show resolved Hide resolved
client/pkg/eventlog/log_segment.go Outdated Show resolved Hide resolved
client/pkg/eventlog/lookup.go Outdated Show resolved Hide resolved
internal/gateway/gateway.go Outdated Show resolved Hide resolved
internal/trigger/trigger/trigger.go Outdated Show resolved Hide resolved
@hwjiangkai
fix review comments
aa43694 
Signed-off-by: jyjiangkai <jyjiangkai@163.com>
ifplusor
ifplusor requested changes Feb 17, 2023
View reviewed changes
client/pkg/api/client.go Outdated Show resolved Hide resolved
client/pkg/eventlog/log_segment.go Outdated Show resolved Hide resolved
@ifplusor ifplusor changed the title refactor: merge append interface feat: merge append interface Feb 17, 2023
@ifplusor ifplusor changed the title feat: merge append interface feat!: merge append interface Feb 17, 2023
@hwjiangkai
fix review comments
12fe77c 
Signed-off-by: jyjiangkai <jyjiangkai@163.com>
ifplusor
ifplusor approved these changes Feb 17, 2023
View reviewed changes
Copy link
Collaborator

@ifplusor ifplusor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ifplusor ifplusor merged commit d2adf55 into main Feb 17, 2023
@hwjiangkai hwjiangkai deleted the client branch March 2, 2023 07:28
wenfengwang pushed a commit that referenced this pull request Mar 23, 2023
@hwjiangkai
feat!: merge append interface (#433)
9337412 
Signed-off-by: jyjiangkai <jyjiangkai@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifplusor ifplusor ifplusor approved these changes

@xdlbdy xdlbdy Awaiting requested review from xdlbdy

@wenfengwang wenfengwang Awaiting requested review from wenfengwang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hwjiangkai @ifplusor