Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: subscription update logic #424

Merged
merged 4 commits into from
Feb 13, 2023
Merged

fix: subscription update logic #424

merged 4 commits into from
Feb 13, 2023

Conversation

hwjiangkai
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Signed-off-by: jyjiangkai <jyjiangkai@163.com>
Signed-off-by: jyjiangkai <jyjiangkai@163.com>
Signed-off-by: jyjiangkai <jyjiangkai@163.com>
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #424 (b2962fc) into main (2a78cb5) will increase coverage by 0.03%.
The diff coverage is 12.50%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
+ Coverage   57.71%   57.74%   +0.03%     
==========================================
  Files         180      181       +1     
  Lines       14614    14667      +53     
==========================================
+ Hits         8434     8470      +36     
- Misses       5552     5573      +21     
+ Partials      628      624       -4     
Impacted Files Coverage Δ
internal/gateway/proxy/proxy.go 23.18% <0.00%> (-1.92%) ⬇️
...ve/transform/action/strings/capitalize_sentence.go 100.00% <100.00%> (ø)
internal/primitive/transform/runtime/init.go 94.87% <100.00%> (+0.13%) ⬆️
internal/timer/timingwheel/timingwheel.go 79.80% <0.00%> (+0.76%) ⬆️
internal/controller/eventbus/eventlog/eventlog.go 68.22% <0.00%> (+1.95%) ⬆️
internal/trigger/reader/reader.go 80.15% <0.00%> (+3.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b52b795...b2962fc. Read the comment docs.

Signed-off-by: jyjiangkai <jyjiangkai@163.com>
@wenfengwang wenfengwang changed the title fix: fix subscription update logic fix: subscription update logic Feb 13, 2023
@wenfengwang wenfengwang merged commit 32a5615 into main Feb 13, 2023
@hwjiangkai hwjiangkai deleted the sdk branch February 13, 2023 10:34
wenfengwang pushed a commit that referenced this pull request Mar 23, 2023
* feat: unified proto definition

Signed-off-by: jyjiangkai <jyjiangkai@163.com>

* fix: fix subscription update logic

Signed-off-by: jyjiangkai <jyjiangkai@163.com>

* fix golint

Signed-off-by: jyjiangkai <jyjiangkai@163.com>

---------

Signed-off-by: jyjiangkai <jyjiangkai@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants