Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(timer): cache bus writer for deliver #415

Merged
merged 1 commit into from
Feb 6, 2023
Merged

fix(timer): cache bus writer for deliver #415

merged 1 commit into from
Feb 6, 2023

Conversation

hwjiangkai
Copy link
Contributor

Signed-off-by: jyjiangkai jyjiangkai@163.com

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

wenfengwang
wenfengwang previously approved these changes Feb 6, 2023
Signed-off-by: jyjiangkai <jyjiangkai@163.com>
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #415 (fe63faa) into main (09f3748) will decrease coverage by 3.14%.
The diff coverage is 50.07%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #415      +/-   ##
==========================================
- Coverage   62.72%   59.58%   -3.14%     
==========================================
  Files         133      175      +42     
  Lines       12128    14369    +2241     
==========================================
+ Hits         7607     8562     +955     
- Misses       3977     5194    +1217     
- Partials      544      613      +69     
Impacted Files Coverage Δ
internal/controller/eventbus/server/instance.go 72.04% <ø> (ø)
internal/controller/trigger/storage/secret.go 48.48% <ø> (ø)
...nternal/controller/trigger/storage/subscription.go 54.71% <ø> (ø)
...ernal/controller/trigger/storage/trigger_worker.go 63.41% <ø> (ø)
...rnal/primitive/interceptor/errinterceptor/error.go 0.00% <0.00%> (ø)
.../primitive/interceptor/memberinterceptor/member.go 0.00% <0.00%> (ø)
internal/primitive/vanus/id.go 19.68% <0.00%> (-0.65%) ⬇️
internal/raft/log/recovery.go 52.27% <ø> (ø)
internal/raft/log/wal.go 100.00% <ø> (ø)
internal/store/block/entry.go 70.96% <ø> (ø)
... and 156 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1157347...fe63faa. Read the comment docs.

Copy link
Contributor

@wenfengwang wenfengwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenfengwang wenfengwang merged commit 652b292 into main Feb 6, 2023
hwjiangkai added a commit that referenced this pull request Feb 11, 2023
Signed-off-by: jyjiangkai <jyjiangkai@163.com>
wenfengwang pushed a commit that referenced this pull request Feb 13, 2023
* fix(timer): cache bus writer for deliver (#415)

Signed-off-by: jyjiangkai <jyjiangkai@163.com>

* Simplify generate subcommand

Signed-off-by: jyjiangkai <jyjiangkai@163.com>

---------

Signed-off-by: jyjiangkai <jyjiangkai@163.com>
@hwjiangkai hwjiangkai deleted the fixtimer branch February 13, 2023 10:34
wenfengwang pushed a commit that referenced this pull request Mar 23, 2023
Signed-off-by: jyjiangkai <jyjiangkai@163.com>
wenfengwang pushed a commit that referenced this pull request Mar 23, 2023
* fix(timer): cache bus writer for deliver (#415)

Signed-off-by: jyjiangkai <jyjiangkai@163.com>

* Simplify generate subcommand

Signed-off-by: jyjiangkai <jyjiangkai@163.com>

---------

Signed-off-by: jyjiangkai <jyjiangkai@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants