Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modify subscription name #401

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

xdlbdy
Copy link
Contributor

@xdlbdy xdlbdy commented Jan 8, 2023

Signed-off-by: xdlbdy xdlbdy@gmail.com

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

  • create a subscription name that can't be empty and can't be repeated in an eventbus
  • list subscription support filter with eventbus, name

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Signed-off-by: xdlbdy <xdlbdy@gmail.com>
@codecov
Copy link

codecov bot commented Jan 8, 2023

Codecov Report

Merging #401 (6aa3fff) into main (09f3748) will decrease coverage by 3.16%.
The diff coverage is 49.88%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #401      +/-   ##
==========================================
- Coverage   62.72%   59.55%   -3.17%     
==========================================
  Files         133      172      +39     
  Lines       12128    14129    +2001     
==========================================
+ Hits         7607     8415     +808     
- Misses       3977     5111    +1134     
- Partials      544      603      +59     
Impacted Files Coverage Δ
internal/controller/eventbus/server/instance.go 72.04% <ø> (ø)
internal/controller/trigger/storage/secret.go 48.48% <ø> (ø)
...nternal/controller/trigger/storage/subscription.go 54.71% <ø> (ø)
...ernal/controller/trigger/storage/trigger_worker.go 63.41% <ø> (ø)
...rnal/primitive/interceptor/errinterceptor/error.go 0.00% <0.00%> (ø)
.../primitive/interceptor/memberinterceptor/member.go 0.00% <0.00%> (ø)
internal/primitive/vanus/id.go 19.68% <0.00%> (-0.65%) ⬇️
internal/raft/log/recovery.go 52.27% <ø> (ø)
internal/raft/log/wal.go 100.00% <ø> (ø)
internal/store/block/entry.go 70.96% <ø> (ø)
... and 156 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89f80c3...6aa3fff. Read the comment docs.

Copy link
Contributor

@wenfengwang wenfengwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenfengwang wenfengwang merged commit 0e4588d into vanus-labs:main Jan 9, 2023
wenfengwang pushed a commit that referenced this pull request Mar 23, 2023
Signed-off-by: xdlbdy <xdlbdy@gmail.com>

Signed-off-by: xdlbdy <xdlbdy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants