Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send unexpected MsgAppResp to leader #395

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

ifplusor
Copy link
Collaborator

@ifplusor ifplusor commented Jan 6, 2023

What problem does this PR solve?

Issue Number: None

Problem Summary

follower maybe send unexpected MsgAppResp to leader after new election. (after #313)

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Signed-off-by: James Yin <ywhjames@hotmail.com>
@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #395 (ea9f325) into main (09f3748) will decrease coverage by 3.11%.
The diff coverage is 50.30%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #395      +/-   ##
==========================================
- Coverage   62.72%   59.60%   -3.12%     
==========================================
  Files         133      171      +38     
  Lines       12128    14165    +2037     
==========================================
+ Hits         7607     8443     +836     
- Misses       3977     5127    +1150     
- Partials      544      595      +51     
Impacted Files Coverage Δ
internal/controller/eventbus/server/instance.go 72.04% <ø> (ø)
internal/controller/trigger/storage/secret.go 48.48% <ø> (ø)
...nternal/controller/trigger/storage/subscription.go 54.71% <ø> (ø)
...ernal/controller/trigger/storage/trigger_worker.go 63.41% <ø> (ø)
...rnal/primitive/interceptor/errinterceptor/error.go 0.00% <0.00%> (ø)
.../primitive/interceptor/memberinterceptor/member.go 0.00% <0.00%> (ø)
internal/primitive/vanus/id.go 19.68% <0.00%> (-0.65%) ⬇️
internal/raft/log/recovery.go 52.27% <ø> (ø)
internal/raft/log/wal.go 100.00% <ø> (ø)
internal/store/block/entry.go 70.96% <ø> (ø)
... and 157 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b23e5a...ea9f325. Read the comment docs.

Copy link
Contributor

@wenfengwang wenfengwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenfengwang wenfengwang merged commit 65b7101 into vanus-labs:main Jan 6, 2023
@ifplusor ifplusor deleted the fix-raft-replication branch January 6, 2023 10:17
wenfengwang pushed a commit that referenced this pull request Mar 23, 2023
Signed-off-by: James Yin <ywhjames@hotmail.com>

Signed-off-by: James Yin <ywhjames@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants