Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Publish&Subscribe api #393

Merged
merged 4 commits into from
Jan 6, 2023
Merged

Conversation

hwjiangkai
Copy link
Contributor

Signed-off-by: jyjiangkai jyjiangkai@163.com

What problem does this PR solve?

add Publish&Subscribe api

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Signed-off-by: jyjiangkai <jyjiangkai@163.com>
@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #393 (5176d74) into main (09f3748) will decrease coverage by 3.15%.
The diff coverage is 48.65%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
- Coverage   62.72%   59.57%   -3.16%     
==========================================
  Files         133      171      +38     
  Lines       12128    14096    +1968     
==========================================
+ Hits         7607     8397     +790     
- Misses       3977     5106    +1129     
- Partials      544      593      +49     
Impacted Files Coverage Δ
internal/controller/eventbus/block/block.go 56.09% <0.00%> (ø)
internal/controller/eventbus/server/instance.go 72.04% <ø> (ø)
internal/controller/trigger/storage/secret.go 48.48% <ø> (ø)
...nternal/controller/trigger/storage/subscription.go 54.71% <ø> (ø)
...ernal/controller/trigger/storage/trigger_worker.go 63.41% <ø> (ø)
...rnal/primitive/interceptor/errinterceptor/error.go 0.00% <0.00%> (ø)
.../primitive/interceptor/memberinterceptor/member.go 0.00% <0.00%> (ø)
internal/primitive/vanus/id.go 19.68% <0.00%> (-0.65%) ⬇️
internal/raft/log/recovery.go 52.27% <ø> (ø)
internal/raft/log/wal.go 100.00% <ø> (ø)
... and 153 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1395ee8...5176d74. Read the comment docs.

Signed-off-by: jyjiangkai <jyjiangkai@163.com>
Signed-off-by: jyjiangkai <jyjiangkai@163.com>
internal/gateway/proxy/proxy.go Outdated Show resolved Hide resolved
internal/gateway/proxy/proxy.go Outdated Show resolved Hide resolved
internal/gateway/proxy/proxy.go Show resolved Hide resolved
Signed-off-by: jyjiangkai <jyjiangkai@163.com>
@wenfengwang wenfengwang merged commit 6b23e5a into vanus-labs:main Jan 6, 2023
wenfengwang pushed a commit that referenced this pull request Mar 23, 2023
* feat: add Publish&Subscribe api

Signed-off-by: jyjiangkai <jyjiangkai@163.com>

* fix golint

Signed-off-by: jyjiangkai <jyjiangkai@163.com>

* fix review comments

Signed-off-by: jyjiangkai <jyjiangkai@163.com>

Signed-off-by: jyjiangkai <jyjiangkai@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants