Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix transformer convert array #368

Merged
merged 2 commits into from
Dec 26, 2022

Conversation

xdlbdy
Copy link
Contributor

@xdlbdy xdlbdy commented Dec 26, 2022

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

  • fix: fix transformer convert array
  • transformer add panic conver

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Signed-off-by: xdlbdy <xdlbdy@gmail.com>
Signed-off-by: xdlbdy <xdlbdy@gmail.com>
@codecov
Copy link

codecov bot commented Dec 26, 2022

Codecov Report

Merging #368 (44447fa) into main (09f3748) will increase coverage by 0.09%.
The diff coverage is 61.46%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
+ Coverage   62.72%   62.82%   +0.09%     
==========================================
  Files         133      162      +29     
  Lines       12128    13535    +1407     
==========================================
+ Hits         7607     8503     +896     
- Misses       3977     4437     +460     
- Partials      544      595      +51     
Impacted Files Coverage Δ
internal/controller/eventbus/block/block.go 56.09% <0.00%> (ø)
internal/controller/eventbus/server/instance.go 72.04% <ø> (ø)
internal/controller/trigger/storage/secret.go 48.48% <ø> (ø)
...nternal/controller/trigger/storage/subscription.go 54.71% <ø> (ø)
...ernal/controller/trigger/storage/trigger_worker.go 63.41% <ø> (ø)
...rnal/primitive/interceptor/errinterceptor/error.go 0.00% <0.00%> (ø)
.../primitive/interceptor/memberinterceptor/member.go 0.00% <0.00%> (ø)
internal/primitive/vanus/id.go 19.68% <0.00%> (-0.65%) ⬇️
internal/raft/log/wal.go 100.00% <ø> (ø)
internal/store/block/raft/appender.go 0.00% <0.00%> (ø)
... and 100 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f578245...44447fa. Read the comment docs.

@wenfengwang wenfengwang merged commit 41b10a8 into vanus-labs:main Dec 26, 2022
@xdlbdy xdlbdy deleted the fix_transformer_convert_array branch December 26, 2022 08:41
wenfengwang pushed a commit that referenced this pull request Mar 23, 2023
* fix: transformer data type not array convert to array

Signed-off-by: xdlbdy <xdlbdy@gmail.com>

* feat: transformer add panic conver

Signed-off-by: xdlbdy <xdlbdy@gmail.com>

Signed-off-by: xdlbdy <xdlbdy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants