Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: error code reconstruction #340

Merged
merged 1 commit into from
Dec 15, 2022
Merged

feat: error code reconstruction #340

merged 1 commit into from
Dec 15, 2022

Conversation

hwjiangkai
Copy link
Contributor

Error code reconstruction

Signed-off-by: jyjiangkai jyjiangkai@163.com

What problem does this PR solve?

error code reconstruction

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #340 (d1cd465) into main (09f3748) will increase coverage by 0.26%.
The diff coverage is 61.62%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #340      +/-   ##
==========================================
+ Coverage   62.72%   62.98%   +0.26%     
==========================================
  Files         133      143      +10     
  Lines       12128    13087     +959     
==========================================
+ Hits         7607     8243     +636     
- Misses       3977     4262     +285     
- Partials      544      582      +38     
Impacted Files Coverage Δ
internal/controller/eventbus/block/block.go 56.09% <0.00%> (ø)
internal/controller/eventbus/server/instance.go 72.04% <ø> (ø)
internal/controller/eventbus/server/manager.go 66.66% <ø> (ø)
internal/controller/trigger/storage/secret.go 48.48% <ø> (ø)
...nternal/controller/trigger/storage/subscription.go 54.71% <ø> (ø)
...ernal/controller/trigger/storage/trigger_worker.go 63.41% <ø> (ø)
...rnal/primitive/interceptor/errinterceptor/error.go 0.00% <0.00%> (ø)
.../primitive/interceptor/memberinterceptor/member.go 0.00% <0.00%> (ø)
internal/primitive/vanus/id.go 19.84% <0.00%> (-0.49%) ⬇️
internal/raft/log/wal.go 100.00% <ø> (ø)
... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3052477...d1cd465. Read the comment docs.

Signed-off-by: jyjiangkai <jyjiangkai@163.com>
Copy link
Contributor

@wenfengwang wenfengwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenfengwang wenfengwang merged commit dcfb3b0 into main Dec 15, 2022
@hwjiangkai hwjiangkai deleted the error-bak branch December 15, 2022 16:58
wenfengwang pushed a commit that referenced this pull request Mar 23, 2023
Signed-off-by: jyjiangkai <jyjiangkai@163.com>

Signed-off-by: jyjiangkai <jyjiangkai@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants