Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): raft commit ahead of stable entries #325

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

ifplusor
Copy link
Collaborator

@ifplusor ifplusor commented Dec 9, 2022

What problem does this PR solve?

Issue Number: None

Problem Summary

raft commit index if ahead of stable entries after #313

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #325 (03e74f1) into main (09f3748) will increase coverage by 0.28%.
The diff coverage is 62.52%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #325      +/-   ##
==========================================
+ Coverage   62.72%   63.01%   +0.28%     
==========================================
  Files         133      143      +10     
  Lines       12128    13055     +927     
==========================================
+ Hits         7607     8226     +619     
- Misses       3977     4253     +276     
- Partials      544      576      +32     
Impacted Files Coverage Δ
internal/controller/eventbus/eventlog/eventlog.go 66.66% <ø> (ø)
internal/primitive/vanus/id.go 19.84% <0.00%> (-0.49%) ⬇️
internal/raft/log/wal.go 100.00% <ø> (ø)
internal/store/block/raft/appender.go 0.00% <0.00%> (ø)
internal/store/block/raft/snapshot.go 0.00% <0.00%> (ø)
internal/store/block/raft/transport.go 0.00% <0.00%> (ø)
internal/store/io/file_linux.go 0.00% <0.00%> (ø)
internal/store/segment/server.go 13.32% <0.00%> (-0.11%) ⬇️
internal/store/vsb/block.go 46.34% <0.00%> (ø)
internal/store/vsb/block_seek.go 0.00% <0.00%> (ø)
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8236094...03e74f1. Read the comment docs.

Copy link
Contributor

@wenfengwang wenfengwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenfengwang wenfengwang merged commit 435f314 into vanus-labs:main Dec 9, 2022
@ifplusor ifplusor deleted the fix-ahead-commit branch December 10, 2022 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants