Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add timer metrics #254

Merged
merged 1 commit into from
Sep 15, 2022
Merged

feat: add timer metrics #254

merged 1 commit into from
Sep 15, 2022

Conversation

hwjiangkai
Copy link
Contributor

What problem does this PR solve?

add timer metrics

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #254 (5abca24) into main (ca600ab) will decrease coverage by 0.00%.
The diff coverage is 63.63%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
- Coverage   64.00%   63.99%   -0.01%     
==========================================
  Files         129      129              
  Lines       11575    11585      +10     
==========================================
+ Hits         7408     7414       +6     
- Misses       3643     3647       +4     
  Partials      524      524              
Impacted Files Coverage Δ
internal/timer/timingwheel/timingwheel.go 79.31% <63.63%> (-0.39%) ⬇️
internal/gateway/gateway.go 69.60% <0.00%> (-0.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca600ab...5abca24. Read the comment docs.

@ifplusor ifplusor added this to the v0.3 milestone Sep 14, 2022
Copy link
Contributor

@wenfengwang wenfengwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ifplusor ifplusor merged commit e16cac3 into vanus-labs:main Sep 15, 2022
wenfengwang pushed a commit that referenced this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants