Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: images support multi platform #247

Merged
merged 2 commits into from
Sep 13, 2022
Merged

build: images support multi platform #247

merged 2 commits into from
Sep 13, 2022

Conversation

xdlbdy
Copy link
Contributor

@xdlbdy xdlbdy commented Sep 8, 2022

Signed-off-by: delu delu.xu@linkall.com

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary

images support multi platform

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@xdlbdy xdlbdy requested a review from ifplusor September 8, 2022 09:56
@xdlbdy xdlbdy changed the title test: images support multi platform build: images support multi platform Sep 8, 2022
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #247 (6a42adf) into main (ca600ab) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #247   +/-   ##
=======================================
  Coverage   64.00%   64.00%           
=======================================
  Files         129      129           
  Lines       11575    11575           
=======================================
  Hits         7408     7408           
  Misses       3643     3643           
  Partials      524      524           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca600ab...6a42adf. Read the comment docs.

Signed-off-by: delu <delu.xu@linkall.com>
Signed-off-by: delu <delu.xu@linkall.com>
Copy link
Contributor

@wenfengwang wenfengwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenfengwang wenfengwang merged commit cf550e9 into vanus-labs:main Sep 13, 2022
@ifplusor ifplusor added this to the v0.3 milestone Sep 14, 2022
ifplusor pushed a commit that referenced this pull request Sep 14, 2022
wenfengwang pushed a commit that referenced this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants