-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(timer): discard events if no eventbus causes failed delivery #239
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
==========================================
- Coverage 63.50% 62.33% -1.17%
==========================================
Files 118 140 +22
Lines 11353 12169 +816
==========================================
+ Hits 7210 7586 +376
- Misses 3589 4040 +451
+ Partials 554 543 -11
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: James Yin <ywhjames@hotmail.com>
What problem does this PR solve?
Issue Number: close #191
Problem Summary
What is changed and how does it work?
Check List
Tests