Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(timer): discard events if no eventbus causes failed delivery #239

Merged
merged 4 commits into from
Sep 7, 2022
Merged

fix(timer): discard events if no eventbus causes failed delivery #239

merged 4 commits into from
Sep 7, 2022

Conversation

hwjiangkai
Copy link
Contributor

What problem does this PR solve?

  1. discard the delivery failure event when eventbus not found
  2. add recover to avoid crash

Issue Number: close #191

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #239 (652ef21) into main (3f72df1) will decrease coverage by 1.16%.
The diff coverage is 96.77%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
- Coverage   63.50%   62.33%   -1.17%     
==========================================
  Files         118      140      +22     
  Lines       11353    12169     +816     
==========================================
+ Hits         7210     7586     +376     
- Misses       3589     4040     +451     
+ Partials      554      543      -11     
Impacted Files Coverage Δ
internal/timer/timingwheel/timingwheel.go 78.47% <90.00%> (+0.33%) ⬆️
internal/timer/timingwheel/bucket.go 99.02% <100.00%> (+0.04%) ⬆️
internal/store/segment/server.go 13.90% <0.00%> (-27.19%) ⬇️
internal/store/block/entry.go 95.65% <0.00%> (-4.35%) ⬇️
internal/store/meta/snapshot.go 31.70% <0.00%> (ø)
internal/store/block/file/block.go
internal/store/block/file/append.go
internal/store/block/replica/replica.go
internal/store/block/file/index.go
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f72df1...652ef21. Read the comment docs.

Copy link
Collaborator

@ifplusor ifplusor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ifplusor ifplusor changed the title fix(timer): discard the delivery failure event when eventbus not found fix(timer): discard the delivery failure event if eventbus not found Sep 7, 2022
@ifplusor ifplusor changed the title fix(timer): discard the delivery failure event if eventbus not found fix(timer): discard events if no eventbus causes failed delivery Sep 7, 2022
@ifplusor ifplusor merged commit f84d1e1 into vanus-labs:main Sep 7, 2022
@ifplusor ifplusor added this to the v0.3 milestone Sep 7, 2022
@hwjiangkai hwjiangkai deleted the bugfix branch September 7, 2022 09:18
wenfengwang pushed a commit that referenced this pull request Mar 23, 2023
Co-authored-by: James Yin <ywhjames@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

timing message consume failed when eventbus not exist
2 participants