-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(client): read events will be blocked when switching to a new segment #235
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #235 +/- ##
==========================================
- Coverage 64.38% 64.37% -0.01%
==========================================
Files 115 115
Lines 11269 11275 +6
==========================================
+ Hits 7255 7258 +3
- Misses 3462 3464 +2
- Partials 552 553 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
Issue Number: NO
Problem Summary
In now version, it will be sucked to get events from segments that maximum offset less than the target offset, which was caused by the client updating route info mechanism: it maintains the last segment's
endOffset
as MAXIMUM_INT64, so exceeded offset doesn't trigger route info updating, only each periodical(30s) task will update route info and then consuming back to normal.What is changed and how does it work?
Add
force
flag to force update route info when client meetsOverflow
error.Check List
Tests
it can be seen the blocking time reduced to 1-2s from 10-30s