Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add version sub-command to vsctl #183

Merged
merged 3 commits into from
Aug 10, 2022
Merged

feat: add version sub-command to vsctl #183

merged 3 commits into from
Aug 10, 2022

Conversation

wenfengwang
Copy link
Contributor

What problem does this PR solve?

Add vsctl version

Problem Summary

Add vsctl version

What is changed and how does it work?

use ldflags to add build info to vsctl when complie

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
~/personal/workspace/linkall/vanus on vsctl-version > make build-cmd GOOS=darwin GOARCH=arm64 VERSION=v0.2.0

~/personal/workspace/linkall/vanus on vsctl-version > vsctl version --format json                                                                                                                  
{
  "BuildDate": "2022-08-10_11:11:43",
  "GitCommit": "6fc75c1",
  "GoVersion": "go1.17.3",
  "Platform": "darwin/arm64",
  "Version": "v0.2.0"
}

image

  • No code

@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #183 (2032bef) into main (6fc75c1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #183   +/-   ##
=======================================
  Coverage   61.73%   61.73%           
=======================================
  Files         114      114           
  Lines       10841    10841           
=======================================
  Hits         6693     6693           
  Misses       3642     3642           
  Partials      506      506           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fc75c1...2032bef. Read the comment docs.

@wenfengwang wenfengwang merged commit ecb6c25 into main Aug 10, 2022
@wenfengwang wenfengwang deleted the vsctl-version branch August 11, 2022 03:38
wenfengwang added a commit that referenced this pull request Mar 23, 2023
* feat: add version sub-command to vsctl

* add timezone to builddate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants