Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add destructive test case #149

Merged
merged 1 commit into from
Jul 14, 2022
Merged

ci: add destructive test case #149

merged 1 commit into from
Jul 14, 2022

Conversation

hwjiangkai
Copy link
Contributor

@hwjiangkai hwjiangkai commented Jul 12, 2022

What problem does this PR solve?

add destructive test case

Issue Number: related #142

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #149 (021d88b) into main (809abab) will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
+ Coverage   52.19%   52.41%   +0.21%     
==========================================
  Files         103      103              
  Lines        8828     8828              
==========================================
+ Hits         4608     4627      +19     
+ Misses       3888     3875      -13     
+ Partials      332      326       -6     
Impacted Files Coverage Δ
internal/store/wal/wal.go 91.50% <0.00%> (+1.15%) ⬆️
internal/gateway/grpc_proxy.go 75.18% <0.00%> (+12.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 809abab...021d88b. Read the comment docs.

Copy link
Contributor

@wenfengwang wenfengwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hwjiangkai hwjiangkai merged commit 32abb7f into vanus-labs:main Jul 14, 2022
wenfengwang pushed a commit that referenced this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants