Added persistence to seektime for playing songs #923
Conversation
|
I'd rather implement something like bookmarks: If i understood the code correctly, it would always seek to the last known position of a song. That might be nice for an audiobook player, but we are foremost a music player in which such a behavior would be super confusing. |
|
That is exactly why i wanted to know when to start from the last known timestamp. My current implementation which i have yet to commit adds the ability to mark an album so that songs from this album are getting played from the last known timestamp. Everything else starts at the beginning. Additionally, you can set it so that the default is inverted: Everything remembers, and you set an album to not remembered, but that is not the default |
|
Now you have the full ui where the default does not differ from the current master. Only if you decide to change something, the track starts at the last position. What i want to add is a button that starts the selected album at the last track that was played |
added migration for missing database entries
|
@adrian-bl how do i trigger the databasemigration, it seems to ignore the updated versionstring (and subsequently crashes the app if you update an old version) |
|
You probably already executed the app once after you updated DATABASE_VERSION but before the SQL was ready (android stores the latest version it ever saw). Check the logcat - you can also try to increment the DB version again. |
|
Yeah, i guess that was the error, my non emulator device worked flawlessly |
newhinton
changed the title
|
This should be done now You can mark an album to remember the last track and position, or you can set this app to remember it always (except you "unmark" an album) If you set it to remember this in the default, it starts playing the clicked album in the libraryview, except you marked the album to not remember the position |
| @@ -419,6 +432,20 @@ private void pickSongs(Intent intent, final int action) | |||
| query.mode = modeForAction[effectiveAction]; | |||
| PlaybackService.get(this).addSongs(query); | |||
|
|
|||
| //Delay this a short time, because sometimes the playlist is not ready and the queue is empty so it cannot set the track properly | |||
There was a problem hiding this comment.
No: if anything, that should happen in a callback.
Sleeping a hardcoded amount of time will always be a source of bugs (and a horrible hack at best).
| if (type == MediaUtils.TYPE_PLAYLIST) { | ||
| fm.add(CTX_MENU_RENAME_PLAYLIST, 0, R.drawable.menu_edit, R.string.rename).setIntent(rowData); | ||
| } else if (rowData.getBooleanExtra(LibraryAdapter.DATA_EXPANDABLE, false)) { | ||
| fm.add(CTX_MENU_EXPAND, 2, R.drawable.menu_expand, R.string.expand).setIntent(rowData); | ||
| } | ||
|
|
||
| int timestampstate = MediaLibrary.getAlbumUseSongTimestamp(this, rowData.getLongExtra("id", LibraryAdapter.INVALID_ID)); |
There was a problem hiding this comment.
This would block the UI thread: you shouldn't run SQL queries in the main thread.
| delay=5000; | ||
| //Log.d(TAG, "Long Delay: "+delay); | ||
| } | ||
| mHandler.postDelayed(this, delay); |
There was a problem hiding this comment.
Wait: so this code performs an SQL upadte ever 500 / 5000ms?
That's not a cheap operation and will have significant effects on the battery consumption of the app.
This must be event driven: polling the play state is just completely wrong.
There was a problem hiding this comment.
How can this be event driven? As far as i know the mediaplayer does not provide a callback, so that polling is the only way (The documentation also suggests to use the getCurrentPosition() call to keep track of the playback progress)
Albeit, i have adjusted the code to stop updating when the playback is stopped, and increased the normal delay to 2 seconds, which at least reduces the load by 75%
What we can do additionally is to store the value not directly in the database, but in a shared preference every two seconds, and only update the database value every minute (and on application restart if it crashed for whatever reason, and always before we start a new track) but i am not sure if that is computationally more easy than just writing to the database
There was a problem hiding this comment.
As far as i know the mediaplayer does not provide a callback
You want to save the position if the song was paused or changed: vanilla has hooks for that.
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
… play-button press) Signed-off-by: fnuesse <felix.nuesse@t-online.de>
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
…ixed and the last remembered position was a thousand times smaller than expected Signed-off-by: fnuesse <felix.nuesse@t-online.de>
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
This pr adds the ability to store the last known time of a song in the database. Currently if the app restarts or crashes, it loads the last known timestamp for the song, and starts playing from there. Each song has its own timestamp and starts always at this timestamp.
Todo/discussion:
When should this media player start from the remembered position?
I tend to 1. but i think 3. could also be a good idea (maybe even a combination of all 3)
Also i want to implement that if you play a full album, it should play the last played song at the last remembered time (obeying the rules mentioned above)
closes #841