feat: validate media queries #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 68e8d1a The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mattcompiles
approved these changes
Apr 13, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some basic CSS media query linting (see: #480).
At work, we've shipped a couple of bugs because an invalid media query wasn't caught during code review (eg.
@media (max-width: 600px). CSSType doesn't catch this, nor does Vanilla Extract. It looks like CSSType might tackle it in the future.I wanted to see if I could put something quick together this weekend so this is that attempt. I also tried doing a RegEx attempt but that ended up getting pretty unwieldy (similar to this: https://github.com/niksy/regex-css-media-query).
Would love to hear if you had any ideas on how to tackle this!