-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use realistic file paths in file scopes #647
Conversation
🦋 Changeset detectedLatest commit: 340dc28 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Looks good to me and does solve the file path problem. We should verify that this doesn't regress the fix for #427. |
@graup Thanks for reminding me about #427. I think it's possible this change could affect it. Thinking we should potentially make the filenames look absolute by prefixing with a |
@graup Looking to merge this soon. Happy with how it changes the rollup output? Seems cleaner to me but does make the custom asset file name test/docs a bit strange. |
It does but I'm fine with that. That's optional anyway, no big deal if users don't get that. It works fine with the default setting too. To clarify, I wrote the rollup plugin and docs with this PR in mind. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR is the start of getting rid of package names in file scopes, with the intention of using more realistic file paths for the app being compiled. This hopefully solves (or helps to solve) a bunch of issues with file resolution and file chunk naming.
Fixes #462
Fixes #631