Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types field to all package's package.json #1335

Merged
merged 3 commits into from
May 22, 2024

Conversation

askoufis
Copy link
Contributor

@askoufis askoufis commented Mar 2, 2024

Fixes #983.

It seems like a top-level types field is already present in all packages (how does this get here? changesets? does npm infer it?), but sub-path exports do not have one.

Copy link

changeset-bot bot commented Mar 2, 2024

🦋 Changeset detected

Latest commit: 4efb34a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 33 packages
Name Type
@vanilla-extract/babel-plugin-debug-ids Patch
@vanilla-extract/esbuild-plugin-next Patch
@vanilla-extract/parcel-transformer Patch
@vanilla-extract/esbuild-plugin Patch
@vanilla-extract/jest-transform Patch
@vanilla-extract/webpack-plugin Patch
@vanilla-extract/rollup-plugin Patch
@vanilla-extract/integration Patch
@vanilla-extract/next-plugin Patch
@vanilla-extract/vite-plugin Patch
@vanilla-extract/sprinkles Patch
@vanilla-extract/dynamic Patch
@vanilla-extract/private Patch
@vanilla-extract/recipes Patch
@vanilla-extract/css-utils Patch
@vanilla-extract/css Patch
@vanilla-extract-private/test-helpers Patch
@fixtures/next-app-router Patch
@fixtures/next-pages-router Patch
@vanilla-extract-private/tests Patch
vanilla-extract-example-remix Patch
@fixtures/sprinkles Patch
@fixtures/features Patch
@fixtures/themed Patch
@fixtures/recipes Patch
@fixtures/layers Patch
@fixtures/low-level Patch
@fixtures/template-string-paths Patch
@fixtures/thirdparty Patch
@fixtures/unused-modules Patch
@fixtures/thirdparty-dep Patch
@fixtures/thirdparty-dep-dep Patch
vanilla-extract-example-webpack-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@askoufis askoufis requested a review from a team March 4, 2024 09:25
@EvanLovely
Copy link

This is approved; any chance it can get merged @mattcompiles ?

@askoufis askoufis enabled auto-merge (squash) May 21, 2024 23:56
@askoufis askoufis merged commit b8a99e4 into master May 22, 2024
11 checks passed
@askoufis askoufis deleted the package-json-types-field branch May 22, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No types field in package.json exports entries
3 participants