Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwright config update, move snapshots to their own folder #1334

Merged
merged 3 commits into from
Mar 2, 2024

Conversation

renrizzolo
Copy link
Contributor

@renrizzolo renrizzolo commented Feb 29, 2024

  • update the playwright config to add a custom snapshotPathTemplate for snapshots, which also removes the need for the _autoSnapshotSuffix workaround.
  • move the snapshots to the new e2e/snapshots dir

Note: this PR is part of future changes required for next e2e testing (#1203)

Copy link

changeset-bot bot commented Feb 29, 2024

⚠️ No Changeset found

Latest commit: c2d14d6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@renrizzolo renrizzolo changed the title Playwright upgrade Playwright config update, move snapshots to their own folder Feb 29, 2024
@renrizzolo renrizzolo marked this pull request as ready for review February 29, 2024 10:58
playwright.config.ts Outdated Show resolved Hide resolved
@askoufis askoufis merged commit dc5ace2 into vanilla-extract-css:master Mar 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants