Add createCompiler to integration package
#1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 06cb763 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
markdalgleish
changed the title
createCompiler functioncreateCompiler to integration package
mattcompiles
reviewed
Mar 9, 2023
packages/integration/src/compiler.ts
Outdated
| getIdentOption: () => identifiers, | ||
| onBeginFileScope: (fileScope) => { | ||
| // Before evaluating a file, reset the cache for it | ||
| cssByFileScope.set(fileScope.filePath, []); |
There was a problem hiding this comment.
We should scope the cache to include packageName from the filescope
packages/integration/src/compiler.ts
Outdated
Comment on lines
35
to
37
| for (const importedModule of moduleNode.importedModules) { | ||
| queue.push(importedModule); | ||
| } |
There was a problem hiding this comment.
Suggested change
| for (const importedModule of moduleNode.importedModules) { | |
| queue.push(importedModule); | |
| } | |
| queue.push(...moduleNode.importedModules); |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new compiler to the integration package, powered by vite-node.
This allows us to cache results across builds which can dramatically improve build performance, particularly for esbuild consumers since it doesn't automatically manage caching of plugins.
I've also added a new esbuild plugin that makes use of the new compiler, but it's been marked as private for now. This allows us to run tests and fixtures against the new plugin without forcing us to release it immediately. In the meantime, since Remix uses
@vanilla-extract/integrationdirectly, Remix will be able to roll out the new Vanilla Extract compiler immediately without waiting for all official plugins to be migrated.You can run a fixture against the new compiler like this: