fix: change the order of function overloading(createTheme) (#1410)

Co-authored-by: Adam Skoufis <askoufis@users.noreply.github.com>
vanilla-extract-css · Jun 14, 2024 · 99e974b · 99e974b
1 parent b86f3f5
commit 99e974b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/.changeset/shiny-fans-refuse.md b/.changeset/shiny-fans-refuse.md
@@ -0,0 +1,5 @@
+---
+"@vanilla-extract/css": patch
+---
+
+Fixes a bug causing incorrect type inference when calling `createTheme` with a theme contract
diff --git a/packages/css/src/theme.ts b/packages/css/src/theme.ts
@@ -41,15 +41,15 @@ export function createGlobalTheme(
   }
 }
 
-export function createTheme<ThemeTokens extends Tokens>(
-  tokens: ThemeTokens,
-  debugId?: string,
-): [className: string, vars: ThemeVars<ThemeTokens>];
 export function createTheme<ThemeContract extends Contract>(
   themeContract: ThemeContract,
   tokens: MapLeafNodes<ThemeContract, string>,
   debugId?: string,
 ): string;
+export function createTheme<ThemeTokens extends Tokens>(
+  tokens: ThemeTokens,
+  debugId?: string,
+): [className: string, vars: ThemeVars<ThemeTokens>];
 export function createTheme(arg1: any, arg2?: any, arg3?: string): any {
   const themeClassName = generateIdentifier(
     typeof arg2 === 'object' ? arg3 : arg2,