Skip to content

Commit

Permalink
chore: add TODO to allow-listed generation of unused resnames (google…
Browse files Browse the repository at this point in the history
  • Loading branch information
miraleung authored Aug 6, 2021
1 parent b8310ee commit a0f88b9
Showing 1 changed file with 2 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,8 @@ public static GapicContext parse(CodeGeneratorRequest request) {

Preconditions.checkState(!services.isEmpty(), "No services found to generate");

// TODO(vam-google): Figure out whether we should keep this allowlist or bring
// back the unused resource names for all APIs.
// Temporary workaround for Ads, who still need these resource names.
if (services.get(0).protoPakkage().startsWith("google.ads.googleads.v")) {
Function<ResourceName, String> typeNameFn =
Expand Down

0 comments on commit a0f88b9

Please sign in to comment.