Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: simplify appendArgsKeyBytes #1898

Closed
wants to merge 1 commit into from
Closed

refactor: simplify appendArgsKeyBytes #1898

wants to merge 1 commit into from

Conversation

alexandear
Copy link
Contributor

The function appendArgsKeyBytes is always called with the first parameter nil, so we can remove it.

@erikdubbelboer
Copy link
Collaborator

Nice find. I wonder if instead we should replace some of these nil with h.bufK so they don't allocate memory. Could you maybe have a look at that?

@alexandear alexandear marked this pull request as draft November 14, 2024 12:22
@alexandear alexandear closed this Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandear @erikdubbelboer