gracefully shuts down bug.

[alpha-baby]

when invocate func (s *Server) Shutdown() error, should return header: Connection: close

if you sure it's a bug, i will commit a PR to fix it.

[erikdubbelboer]

Good idea. I think here:

fasthttp/server.go

Line 2199 in 5661df8

connectionClose = connectionClose || ctx.Response.ConnectionClose()

It should include || atomic.LoadInt32(&s.stop) == 1

Can you test this and make a pull request? Thanks.

[kirillDanshin]

hey @alpha-baby, thanks for your report.

I'm concerned this one could introduce bugs in case of fasthttp service being behind ALB, 'cause the client would close the connection to ALB, then open it again unnecessarily, which will cause a spike in load during rollouts. I'd prefer having this under an option

[erikdubbelboer]

@kirillDanshin good point I didn't think of that. @alpha-baby can you add an option to the Server struct for this. Something like CloseOnShutdown so the default is false which doesn't break anything for current users.

[alpha-baby]

@kirillDanshin good point I didn't think of that. @alpha-baby can you add an option to the Server struct for this. Something like CloseOnShutdown so the default is false which doesn't break anything for current users.

Ok,tomorrow i will commit new code.

[alpha-baby]

hey @alpha-baby, thanks for your report.

I'm concerned this one could introduce bugs in case of fasthttp service being behind ALB, 'cause the client would close the connection to ALB, then open it again unnecessarily, which will cause a spike in load during rollouts. I'd prefer having this under an option

before i commit this PR, tcp connection also will be close when you call func (s *Server) Shutdown() error.

Closing connection source code in here: https://github.com/valyala/fasthttp/blob/master/server.go#L2303

[erikdubbelboer]

The connections being closed is what is supposed to happen. What people might not want is the connection from the client to the loadbalancer being terminated as well if there is a loadbalancer.