Skip to content

feat(graphql-java-client-validator-plugin) S3508: java gql client sch… #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

ukondoz
Copy link
Collaborator

@ukondoz ukondoz commented Jun 16, 2023

Summary

maven plugin to validate the graphql java client against the code-gen

Notes for PR Reviewers

none

How Has This Been Tested?

unit test and manual test

Checklist:

To Raise Draft PR

  • My PR Title follows the format type(scope)[!]: Ref: Brief Title
  • My code meets all style guidelines / linting checks etc.
  • I have performed a self-review of my code.
  • I have commented my code and made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Before Final Review

  • I have created a draft PR free of merge conflicts and verified behaviour in a review environment.
  • All errors and warnings in the review environment have been addressed.

Reviewer Checklist

  • I have been able to build and run the PR locally.optional
  • I have verified that the change works as intended in the review environment

Shout-outs:

[ @ anyone else here who may not need to be a reviewer, but should be notified. ]

Support Notes:

[Special instructions for troubleshooting should things go wrong while the author is unavailable]

Copy link

@aditya-valstro aditya-valstro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool PR. I've never actually seen a Maven plugin being created. Love the Pokemon theme for testing. Approved pending spelling and nitpick changes.

@ukondoz ukondoz force-pushed the ukondoz/S3508-java-graphql-client-schema-safety branch from 2f039f9 to d91f511 Compare June 26, 2023 14:56
@jeffkni
Copy link

jeffkni commented Jun 26, 2023

Hi Ulku - there were a stack of spelling / grammar mistakes in the README
==> Which in no way takes away from how cool this PR is !! <==

I made an edited README and pasted it into the PR review. Maybe if you go '...' -> Edit you can see the original Markdown.
Mostly I suggested giving a bit of context to the "why" and made some typo edits. We also tend to use # / ## / ### for markdown instead of ==== / -----

I also like how you can have EXTRA fields in the POJOS and that's ok. I assume SmallRye is also happy if our POJOs have extra fields ?

@jeffkni
Copy link

jeffkni commented Jun 26, 2023

@stuartwallace-valstro this is a new repo. I don't seem to have permission to create new branches in this repo. Can you help ?

@stuartwallace-valstro
Copy link
Contributor

@stuartwallace-valstro this is a new repo. I don't seem to have permission to create new branches in this repo. Can you help ?

I've added @valstro/valstro-engineering as maintainers on this repo.

@ukondoz ukondoz force-pushed the ukondoz/S3508-java-graphql-client-schema-safety branch from d91f511 to f489a9f Compare June 30, 2023 13:18
@ukondoz ukondoz merged commit efdb5ba into main Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants