-
Notifications
You must be signed in to change notification settings - Fork 0
feat(graphql-java-client-validator-plugin) S3508: java gql client sch… #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool PR. I've never actually seen a Maven plugin being created. Love the Pokemon theme for testing. Approved pending spelling and nitpick changes.
src/main/java/com/valstro/plugin/GraphQLJavaClientValidator.java
Outdated
Show resolved
Hide resolved
src/test/java/com/valstro/plugin/GraphQLJavaClientValidatorTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/valstro/plugin/GraphQLJavaClientValidatorTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/valstro/plugin/GraphQLJavaClientValidatorTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/valstro/plugin/GraphQLJavaClientValidatorTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/valstro/plugin/GraphQLJavaClientValidatorTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/valstro/plugin/GraphQLJavaClientValidatorTest.java
Outdated
Show resolved
Hide resolved
2f039f9
to
d91f511
Compare
Hi Ulku - there were a stack of spelling / grammar mistakes in the README I made an edited README and pasted it into the PR review. Maybe if you go '...' -> Edit you can see the original Markdown. I also like how you can have EXTRA fields in the POJOS and that's ok. I assume SmallRye is also happy if our POJOs have extra fields ? |
@stuartwallace-valstro this is a new repo. I don't seem to have permission to create new branches in this repo. Can you help ? |
I've added @valstro/valstro-engineering as maintainers on this repo. |
d91f511
to
f489a9f
Compare
Summary
maven plugin to validate the graphql java client against the code-gen
Notes for PR Reviewers
none
How Has This Been Tested?
unit test and manual test
Checklist:
To Raise Draft PR
Before Final Review
Reviewer Checklist
Shout-outs:
[ @ anyone else here who may not need to be a reviewer, but should be notified. ]
Support Notes:
[Special instructions for troubleshooting should things go wrong while the author is unavailable]