Add process_request_headers/3 to pass options #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change passes provided options from process_arguments/3 to process_request_headers. This enables the user to inject custom headers based on options. The change is backward compatible.
valpackett
requested changes
May 21, 2019
Owner
|
Thanks! |
Contributor
Author
|
@myfreeweb Would you be able to push a release with this fix? |
Owner
|
uploaded 3.1.3 |
Contributor
Author
|
thank you very much. |
iilyak
added a commit
to cloudant/couchdb
that referenced
this pull request
Aug 19, 2019
There were couple of hacks in test/elixir/lib/couch.ex We've got changes needed to remove them into httpotion 3.1.3. The changes were introduced in: - valpackett/httpotion#118 - valpackett/httpotion#130
4 tasks
iilyak
added a commit
to cloudant/couchdb
that referenced
this pull request
Feb 4, 2020
There were couple of hacks in test/elixir/lib/couch.ex We've got changes needed to remove them into httpotion 3.1.3. The changes were introduced in: - valpackett/httpotion#118 - valpackett/httpotion#130
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change passes provided options from process_arguments/3 to
process_request_headers. This enables the user to inject custom
headers based on options. The change is backward compatible.
Fixes #129