Skip to content

Conversation

@OjusWiZard
Copy link
Member

@OjusWiZard OjusWiZard commented Mar 12, 2025

Proposed changes

Support building and pushing the docker image for multiple CPU architectures
Next, the agents' github workflows (like trader) should be updated to use these new options.

Fixes

If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

  • Non-breaking fix (non-breaking change which fixes an issue)
  • Breaking fix (breaking change which fixes an issue)
  • Non-breaking feature (non-breaking change which adds functionality)
  • Breaking feature (breaking change which adds functionality)
  • Refactor (non-breaking change which changes implementation)
  • Messy (mixture of the above - requires explanation!)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the main branch (left side). Also you should start your branch off our main.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have locally run services that could be impacted and they do not present failures derived from my changes
  • Public-facing documentation has been updated with the changes affected by this PR. Even if the provided contents are not in their final form, all significant information must be included.
  • Any backwards-incompatible/breaking change has been clearly documented in the upgrading document.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@OjusWiZard OjusWiZard force-pushed the feat/multiarch-build-image branch from 6c39f27 to cc568c2 Compare March 12, 2025 21:29
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard OjusWiZard force-pushed the feat/multiarch-build-image branch from cc568c2 to d740ac0 Compare March 12, 2025 21:36
Copy link
Collaborator

@Adamantios Adamantios Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you decide to stop using the docker SDK?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Adamantios the two major reasons are:

  1. It doesn't support buildx yet
  2. There was no way to pass multiple platform arguments in the same build call.

)
from autonomy.data import DATA_DIR
from autonomy.deploy.constants import DOCKERFILES
from autonomy.deploy.generators.docker_compose.base import get_docker_client
Copy link
Contributor

@8ball030 8ball030 Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am very very very happy about this, i am currently blocked to get 3.12 support by a couple of dependencies here.

Please see pr;

8ball030/auto_dev#538

AFAICT you guys relied on requests within a fork of valory-docker-compose and the forked repo you have is not oss so i couldnt verify, i believe by removing the dependency we will basically be able to upgrade much more easily

Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@codecov
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.12%. Comparing base (89ae715) to head (f1c7d18).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2314   +/-   ##
=======================================
  Coverage   93.12%   93.12%           
=======================================
  Files         225      225           
  Lines       16366    16354   -12     
=======================================
- Hits        15241    15230   -11     
+ Misses       1125     1124    -1     
Flag Coverage Δ
unittests 93.12% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@OjusWiZard OjusWiZard merged commit a6702c4 into main Mar 18, 2025
63 of 65 checks passed
@OjusWiZard OjusWiZard deleted the feat/multiarch-build-image branch March 18, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants