-
Notifications
You must be signed in to change notification settings - Fork 43
Feat: Support multi platform docker image builds #2314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6c39f27 to
cc568c2
Compare
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
cc568c2 to
d740ac0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you decide to stop using the docker SDK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Adamantios the two major reasons are:
- It doesn't support
buildxyet - There was no way to pass multiple
platformarguments in the same build call.
| ) | ||
| from autonomy.data import DATA_DIR | ||
| from autonomy.deploy.constants import DOCKERFILES | ||
| from autonomy.deploy.generators.docker_compose.base import get_docker_client |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am very very very happy about this, i am currently blocked to get 3.12 support by a couple of dependencies here.
Please see pr;
AFAICT you guys relied on requests within a fork of valory-docker-compose and the forked repo you have is not oss so i couldnt verify, i believe by removing the dependency we will basically be able to upgrade much more easily
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2314 +/- ##
=======================================
Coverage 93.12% 93.12%
=======================================
Files 225 225
Lines 16366 16354 -12
=======================================
- Hits 15241 15230 -11
+ Misses 1125 1124 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Proposed changes
Support building and pushing the docker image for multiple CPU architectures
Next, the agents' github workflows (like trader) should be updated to use these new options.
Fixes
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an
xin the box that appliesChecklist
Put an
xin the boxes that apply.mainbranch (left side). Also you should start your branch off ourmain.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...